Passable exo state #10228
Merged
Passable exo state #10228
+128
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Oct 5, 2024
mhofman
force-pushed
the
mhofman/passable-exo-state
branch
from
518a68b
to
4f07d1c
Compare
Deploying agoric-sdk with
|
| Latest commit: |
4f07d1c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c263c7fa.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-passable-exo-state.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #10170
refs: endojs/endo#1648
best reviewed by ignoring white space
Description
After implementing a change to enforce that heap exo are passable, I found that some things currently stored in heap exos, mostly in tests, are not actually passable. Almost all of them are remotable like objects not marked as
Far, usually related to storage nodes.While I plan on moving the implementation of the checks into endo instead of landing it in agoric-sdk first, I figured we should already fix the issues found.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
See #10170 for passing tests with checks enabled
Upgrade Considerations
As it's a heap zone change, cross upgrade behavior is not involved. In the future any code using a stricter heap zone would need to comply. However heaps zones are used as packages bundled by the contract, and are not provided by liveslots or zcf, so there is no compatibility risk.